-
Notifications
You must be signed in to change notification settings - Fork 440
✨ feat: parse negative integers #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: parse negative integers #470
Conversation
Code looks good Two comments:
(please dd the motivating marker to the message)
|
This adds support for negative integers in the marker syntax parser. This is useful for markers like `+kubebuilder:validation:Minimum`. Signed-off-by: knight42 <anonymousknight96@gmail.com>
1dded1d
to
81b2062
Compare
@DirectXMan12 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @alvaroaleman
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knight42, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hmm, I am almost inclined to say doc update isn't needed because I intuitively expect an int to support negative values (otherwise its an uint)? To give Solly a but of time to respond re docs |
@alvaroaleman that's a fair point. This does just bring things in line with what you might expect. Consider that objection withdrawn. |
/hold cancel |
Signed-off-by: knight42 anonymousknight96@gmail.com
This adds support for negative integers in the marker syntax parser. This is useful for markers like
+kubebuilder:validation:Minimum