From 8d9b8d53486f856c34c3ce7ab58a6fa036599b15 Mon Sep 17 00:00:00 2001 From: Damiano Donati Date: Fri, 8 Apr 2022 01:26:55 +0100 Subject: [PATCH 1/2] pkg: envtest: komega: fix UpdateStatus godoc --- pkg/envtest/komega/default.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/envtest/komega/default.go b/pkg/envtest/komega/default.go index cda848c97c..1325e6bf6a 100644 --- a/pkg/envtest/komega/default.go +++ b/pkg/envtest/komega/default.go @@ -61,7 +61,7 @@ func Update(obj client.Object, f func(), opts ...client.UpdateOption) func() err // UpdateStatus returns a function that fetches a resource, applies the provided update function and then updates the resource's status. // It can be used with gomega.Eventually() like this: // deployment := appsv1.Deployment{ ... } -// gomega.Eventually(k.Update(&deployment, func (o client.Object) { +// gomega.Eventually(k.UpdateStatus(&deployment, func (o client.Object) { // deployment.Status.AvailableReplicas = 1 // return &deployment // })).To(gomega.Scucceed()) From bc7cc6833e4abf609c65ea452a2a268b43ec724a Mon Sep 17 00:00:00 2001 From: Damiano Donati Date: Fri, 8 Apr 2022 11:09:30 +0100 Subject: [PATCH 2/2] pkg: envtest: komega: fix godoc Succeed typos --- pkg/envtest/komega/default.go | 4 ++-- pkg/envtest/komega/interfaces.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/envtest/komega/default.go b/pkg/envtest/komega/default.go index 1325e6bf6a..5d55dd14b9 100644 --- a/pkg/envtest/komega/default.go +++ b/pkg/envtest/komega/default.go @@ -51,7 +51,7 @@ func List(list client.ObjectList, opts ...client.ListOption) func() error { // gomega.Eventually(k.Update(&deployment, func (o client.Object) { // deployment.Spec.Replicas = 3 // return &deployment -// })).To(gomega.Scucceed()) +// })).To(gomega.Succeed()) // By calling the returned function directly it can also be used as gomega.Expect(k.Update(...)()).To(...) func Update(obj client.Object, f func(), opts ...client.UpdateOption) func() error { checkDefaultClient() @@ -64,7 +64,7 @@ func Update(obj client.Object, f func(), opts ...client.UpdateOption) func() err // gomega.Eventually(k.UpdateStatus(&deployment, func (o client.Object) { // deployment.Status.AvailableReplicas = 1 // return &deployment -// })).To(gomega.Scucceed()) +// })).To(gomega.Succeed()) // By calling the returned function directly it can also be used as gomega.Expect(k.UpdateStatus(...)()).To(...) func UpdateStatus(obj client.Object, f func(), opts ...client.UpdateOption) func() error { checkDefaultClient() diff --git a/pkg/envtest/komega/interfaces.go b/pkg/envtest/komega/interfaces.go index d9c41c6a2d..0ec3fe0236 100644 --- a/pkg/envtest/komega/interfaces.go +++ b/pkg/envtest/komega/interfaces.go @@ -45,7 +45,7 @@ type Komega interface { // gomega.Eventually(k.Update(&deployment, func (o client.Object) { // deployment.Spec.Replicas = 3 // return &deployment - // })).To(gomega.Scucceed()) + // })).To(gomega.Succeed()) // By calling the returned function directly it can also be used as gomega.Expect(k.Update(...)()).To(...) Update(client.Object, func(), ...client.UpdateOption) func() error @@ -55,7 +55,7 @@ type Komega interface { // gomega.Eventually(k.Update(&deployment, func (o client.Object) { // deployment.Status.AvailableReplicas = 1 // return &deployment - // })).To(gomega.Scucceed()) + // })).To(gomega.Succeed()) // By calling the returned function directly it can also be used as gomega.Expect(k.UpdateStatus(...)()).To(...) UpdateStatus(client.Object, func(), ...client.UpdateOption) func() error