Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add helpers for common Zap options #646

Merged
merged 1 commit into from
Oct 16, 2019
Merged

✨ Add helpers for common Zap options #646

merged 1 commit into from
Oct 16, 2019

Conversation

DirectXMan12
Copy link
Contributor

This adds helpers for common Zap options, so that users don't have to
write them themselves.

It also fixes the Deprecation warnings to use the standard syntax, and
fixes the options godocs to follow proper godocs format.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2019
@DirectXMan12
Copy link
Contributor Author

cc @mengqiy

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2019
@DirectXMan12 DirectXMan12 mentioned this pull request Oct 16, 2019
Merged
mengqiy
mengqiy reviewed Oct 16, 2019
View reviewed changes
Copy link
Member

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

pkg/log/zap/zap.go Outdated Show resolved Hide resolved
@DirectXMan12
Add helpers for common Zap options
6d830ff 
This adds helpers for common Zap options, so that users don't have to
write them themselves.

It also fixes the Deprecation warnings to use the standard syntax, and
fixes the options godocs to follow proper godocs format.
@mengqiy
Copy link
Member

mengqiy commented Oct 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit ecdbe54 into kubernetes-sigs:master Oct 16, 2019
@DirectXMan12 DirectXMan12 deleted the feature/zap-option-helpers branch October 17, 2019 00:44
@joelanford
Copy link
Member

@DirectXMan12 it doesn't look like the enabled variable is used in func UseDevMode(enabled bool).

Did we mean to use enabled to set the value of o.Development? Or should we just get rid of the enabled parameter, such that the function always sets o.Development to true?

@DirectXMan12
Copy link
Contributor Author

Yeah, that's an accident. I was torn, since it makes it more annoying to have a flag or something for dev mode if you don't have the parameter

@hasbro17 hasbro17 mentioned this pull request Oct 19, 2019
Merged
@micnncim micnncim mentioned this pull request Oct 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy mengqiy left review comments

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DirectXMan12 @k8s-ci-robot @mengqiy @joelanford