-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for multi-value KUBECONFIG #642
✨ Add support for multi-value KUBECONFIG #642
Conversation
Hi @joelanford. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9067116
to
111139f
Compare
/ok-to-test |
/test pull-controller-runtime-test |
111139f
to
840ac8a
Compare
3e5c209
to
2fe837f
Compare
/assign @DirectXMan12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
}) | ||
|
||
AfterEach(func() { | ||
os.Unsetenv(clientcmd.RecommendedConfigPathEnvVar) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a note about where this is set
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds support in
pkg/client/config.GetConfig()
andpkg/client/config.GetConfigWithContext()
to handle multi-value KUBECONFIG environment variable values, as documented in the docs about kubeconfig.It also adds unit tests, which test config loading for the kubeconfig flag, environment variable, and default home directory location. In-cluster configurations are not tested because they require files to exist in hard-coded file system locations.
Closes #564