-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ fakeClient: bump ResourceVersion on write #620
Conversation
Welcome @zaneb! |
Hi @zaneb. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
In a real system, the ResourceVersion of a resource will be incremented whenever it is written to. To allow tests to rely on this, fakeClient should do the same.
199f286
to
916aeed
Compare
In the code we rely on the ResourceVersion of a secret being updated whenever it is changed. However, the fake client used in the unit tests does not currently automatically increment the ResourceVersion on writes: kubernetes-sigs/controller-runtime#620 To provide a realistic test, increment the ResourceVersion manually when updating secrets in the unit tests.
In the code we rely on the ResourceVersion of a secret being updated whenever it is changed. However, the fake client used in the unit tests does not currently automatically increment the ResourceVersion on writes: kubernetes-sigs/controller-runtime#620 To provide a realistic test, increment the ResourceVersion manually when updating secrets in the unit tests.
In the code we rely on the ResourceVersion of a secret being updated whenever it is changed. However, the fake client used in the unit tests does not currently automatically increment the ResourceVersion on writes: kubernetes-sigs/controller-runtime#620 To provide a realistic test, increment the ResourceVersion manually when updating secrets in the unit tests.
In the code we rely on the ResourceVersion of a secret being updated whenever it is changed. However, the fake client used in the unit tests does not currently automatically increment the ResourceVersion on writes: kubernetes-sigs/controller-runtime#620 To provide a realistic test, increment the ResourceVersion manually when updating secrets in the unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @DirectXMan12
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🏃 Design for Simplified Scaffolding
Fix client signatures Drop CVO in favour go library-go Ignore resourceVersion on spec comparisons kubernetes-sigs/controller-runtime#620
In a real system, the ResourceVersion of a resource will be incremented whenever it is written to. To allow tests to rely on this, fakeClient should do the same.