✨ Improve webhook loggings #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
mengqiy
reviewed
May 22, 2019
anthonyho007
force-pushed
the
improve-loggings
branch
from
827c67f
to
218153a
Compare
mengqiy
reviewed
May 28, 2019
pkg/webhook/server.go
Outdated
| @@ -132,6 +134,7 @@ func (s *Server) Start(stop <-chan struct{}) error { | |||
| if _, err := inject.LoggerInto(baseHookLog.WithValues("webhook", hookPath), webhook); err != nil { | |||
| return err | |||
| } | |||
| baseHookLog.Info("loaded webhook in", "webhook path", hookPath) | |||
There was a problem hiding this comment.
IMO we should put it in
controller-runtime/pkg/webhook/server.go
Line 100 in 13ee2bc
baseHookLog.Info("registering webhook", "path", path)
s.webhooks[path] = hook
s.WebhookMux.Handle(path, instrumentedHook(path, hook))
fb99b3c
to
de136cc
Compare
k8s-ci-robot
added
the
lgtm
mengqiy
approved these changes
Jun 1, 2019
mengqiy
added
the
approved
anthonyho007
force-pushed
the
improve-loggings
branch
from
de136cc
to
8805801
Compare
k8s-ci-robot
removed
the
lgtm
anthonyho007
force-pushed
the
improve-loggings
branch
from
8805801
to
5788837
Compare
|
force pushed to sync with master branch |
DirectXMan12
changed the title
DirectXMan12
suggested changes
Jun 3, 2019
anthonyho007
force-pushed
the
improve-loggings
branch
from
5788837
to
db2b454
Compare
|
Hi @DirectXMan12! Instead of logging the entire struct of admissionResponse and admissionRequest, i have selected a couple fields to be included in the logs. Plz let me know if this is okay 😃 ! |
|
that looks a lot better /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anthonyho007, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@anthonyho007 can you please fix the failing tests? |
anthonyho007
force-pushed
the
improve-loggings
branch
from
db2b454
to
ebf29b3
Compare
k8s-ci-robot
removed
the
lgtm
anthonyho007
force-pushed
the
improve-loggings
branch
from
ebf29b3
to
d1c6909
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
anthonyho007
force-pushed
the
improve-loggings
branch
from
d1c6909
to
9f1771c
Compare
anthonyho007
force-pushed
the
improve-loggings
branch
from
9f1771c
to
13d4073
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added more logs at places where it deems necessary. If you guys have any good ideas, please let me know!
Issue: #340