⚠ Bump K8s v0.26.0-alpha.3 #2043
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
pkg/cache/cache.go
Outdated
| AddEventHandler(handler toolscache.ResourceEventHandler) | ||
| // It returns a registration handle for the handler that can be used to remove | ||
| // the handler again. | ||
| AddEventHandler(handler toolscache.ResourceEventHandler) (toolscache.ResourceEventHandlerRegistration, error) |
There was a problem hiding this comment.
@FillZpp can we maybe have to distinct PRs, one that just bumps the deps and a follow-up that changes the interfaces so that our release note tooling will be able to properly call out the EventHandler change?
There was a problem hiding this comment.
Sure, I can do this, but the first one will fail to run golangci-lint and some other tests. Is it ok?
There was a problem hiding this comment.
Maybe just use a tiny wrapper around the upstream AddEventHandler that just does _, _ = AddEventHandler(handler)?
FillZpp
force-pushed
the
bump-k8s-126
branch
from
e7b28b0
to
4c4dc66
Compare
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
FillZpp
force-pushed
the
bump-k8s-126
branch
from
4c4dc66
to
4dafb9e
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: FillZpp FillZpp.pub@gmail.com
Bump K8s v0.26.0-alpha.3
Note that because of the new removal of event handler in K8s 1.26 kubernetes/kubernetes#111122, this PR is a breaking change.
After it merged, I will post a new PR to support removal of watches/controllers for #1884.