Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TLS configuration options for default webhook server creation #2020

Closed
srm09 opened this issue Oct 12, 2022 · 1 comment · Fixed by #2023
Closed

Expose TLS configuration options for default webhook server creation #2020

srm09 opened this issue Oct 12, 2022 · 1 comment · Fixed by #2023

Comments

@srm09
Copy link

srm09 commented Oct 12, 2022

Similar to the flags for Webhook Port and Host, we should also expose flags for setting the minimum TLS version as well as the cipher suites to be used when creating the default webhook server.

Currently, to set the minimum TLS version, a hack would be to call manager.GetWebhookServer().TLSMinVersion before calling manager.Start(). To keep the behavior consistent, it makes sense to introduce new options in the manager.Options struct which allow doing the same.

@mythi
Copy link
Contributor

mythi commented Nov 8, 2022

Currently, to set the minimum TLS version, a hack would be to call manager.GetWebhookServer().TLSMinVersion before calling manager.Start().

I don't think it's true and with this issue fixed we have many ways to get one thing done. AFAICS, without #2023, the webhook settings can be set like:

	webHook := &webhook.Server{
		Port:          9443,
		TLSMinVersion: "1.3",
	}

	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
		...
		WebhookServer:          webHook,
		...
	})

The work done in #1897 triggered another topic to discuss: #1936 but now this is moving to the opposite direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants