Copy packages over from kubebuilder #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lookup controller and compare uid when watchingcontrollerof - Rename packages and functions - Better test coverage
Change watching events to use interface instead of struct
While trying to determine what key to emit for an element without a namespace, I looked at types.ReconcileKey which would emit "/name" which doesn't appear to agree with the rest of the logic in kubebuilder. This fixes types.ReconcileKey to emit the correct string value if namespace is empty as well as adds a method to construct the object from a string.
standardize kubebuilder codegeneration labels to have +kubebuilder: prefix
This changes fixes a bug where generic controller can get stuck in inifite loop while resolving parent object for a generated object. It can happen where we encounter an object with no owner reference while walking up the ancestor tree and lookup paths are not yet done.
This will allow for using the fakeclient to test out controllers.
- Check ENV and applying default binary path for apiserver, etcd under "/usr/local/kubebuilder/bin" befor starting Kubernetes server. So that no need to set TEST_ASSET for testing framework. - For KubeCtl wrapper, keep TEST_ASSET set at this moment.
…ly initialized before they are used.
k8s-ci-robot
added
the
size/XXL
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Copy packages over from kubebuilder
rashmigottipati
added a commit
to rashmigottipati/controller-runtime
that referenced
this pull request
May 21, 2021
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
rashmigottipati
added a commit
to rashmigottipati/controller-runtime
that referenced
this pull request
Jun 7, 2021
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
varshaprasad96
pushed a commit
to varshaprasad96/controller-runtime
that referenced
this pull request
Feb 9, 2022
…-client Clusterscope client
1 task
1 task
This was referenced Nov 13, 2023
fix(deps): update module sigs.k8s.io/controller-runtime to v0.18.0
odubajDT/open-feature-operator#17
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.