✨ Bump golang version to 1.19

[laxmikantbpandhare]

IIRC upstream kubernetes/kubernetes updated the golang version to 1.19 and we are following the same.

It will update the go lang version to 1.19

I already Updated test-infra jobs for controller-runtime and controller-tools to 1.19 PR is here: kubernetes/test-infra#27258

[k8s-ci-robot]

Welcome @laxmikantbpandhare!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @laxmikantbpandhare. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

I think we shouldn't bump the version. If I'm correct this would force all consumers of CR to use Go 1.19 as well.

As long as CR itself doesn't need Go 1.18/19 features it would be probably better to keep 1.17.

[sbueringer]

I think we shouldn't bump the version. If I'm correct this would force all consumers of CR to use Go 1.19 as well.

As long as CR itself doesn't need Go 1.18/19 features it would be probably better to keep 1.17.

Hm looks like k/k uses Go 1.19 now: https://github.com/kubernetes/kubernetes/blob/v1.25.0/go.mod#L9
I guess then it doesn't really matter if we upgrade as well?

[laxmikantbpandhare]

I think we shouldn't bump the version. If I'm correct this would force all consumers of CR to use Go 1.19 as well.
As long as CR itself doesn't need Go 1.18/19 features it would be probably better to keep 1.17.

Hm looks like k/k uses Go 1.19 now: https://github.com/kubernetes/kubernetes/blob/v1.25.0/go.mod#L9 I guess then it doesn't really matter if we upgrade as well?

I checked with @alvaroaleman and decided to follow the suit as it is updated k/k upstream

[sbueringer]

/lgtm

[alvaroaleman]

I think we need to bump golangci-lint to a version with go 1.19 similiar to #1976

That I think might also entail some go fmt changes

[alvaroaleman]

Strictly speaking the above is orthogonal to this change and caused by bumping the go version in the presubmit, but we won't be able to merge anything until we do it 🙃

[laxmikantbpandhare]

I think we need to bump golangci-lint to a version with go 1.19 similiar to #1976

That I think might also entail some go fmt changes

Yup definitely

[sbueringer]

@alvaroaleman @laxmikantbpandhare Is there already someone working on the golangci-lint bump? Otherwise I can help out.

[laxmikantbpandhare]

@alvaroaleman @laxmikantbpandhare Is there already someone working on the golangci-lint bump? Otherwise I can help out.

@sbueringer - I haven't started yet. If you want you can update.

[sbueringer]

@alvaroaleman @laxmikantbpandhare Is there already someone working on the golangci-lint bump? Otherwise I can help out.

@sbueringer - I haven't started yet. If you want you can update.

On it

[vincepri]

/ok-to-test

[sbueringer]

Fix PR: #1987

[sbueringer]

/retest

[alvaroaleman]

/retest

[laxmikantbpandhare]

The certwatcher test suit is failing.

[sbueringer]

/retest

[laxmikantbpandhare]

Looks like the retest worked. @alvaroaleman @sbueringer - Could you please take a look and approve the changes.

[alvaroaleman]

@laxmikantbpandhare there is a merge conflict now, can you please rebase?

[laxmikantbpandhare]

@laxmikantbpandhare there is a merge conflict now, can you please rebase?

@alvaroaleman Did the rebase.

[sbueringer]

/lgtm

Thx!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, laxmikantbpandhare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment