⚠ cache.BuilderWithOptions inherit options from caller #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
joelanford
force-pushed
the
fix-cache-inheritance
branch
from
cdf6208
to
6182d4b
Compare
k8s-ci-robot
added
the
needs-rebase
joelanford
force-pushed
the
fix-cache-inheritance
branch
from
6182d4b
to
62f0538
Compare
k8s-ci-robot
added
size/XL
joelanford
force-pushed
the
fix-cache-inheritance
branch
from
62f0538
to
b0184e1
Compare
There was a problem hiding this comment.
This fix does seem good to me. Except for my questions on having DisableDeepCopyByObject external. But that change isn't made here, and hence not concerning/blocking. Leaving it for others to review.
sbueringer
reviewed
Aug 30, 2022
using cache.BuilderWithOptions does not properly inherit all options passed in from the caller: - scheme was overridden instead of merged - selectors were not inherited at all, even if specified options selectors remained unset - transforms were not inherited at all, even if specified options transforms remained unset - disable deep copy settings were not inherited at all, even if specified options for disabling deep copies remained unset This commit resolves this issues by implementing merge logic for all fields in the cache.Options struct: - Schemes are merged - RESTMapper is chosen by precedence only falling back to inherited options if left unset in specified options - Resync is chosen by precedence only falling back to inherited options if left unset in specified options - Namespace is chosen by precedence only falling back to inherited options if left unset in specified options - Selectors are merged. If both inherited and specified Options defined selectors for a given type, those selectors are merged via logical AND. - DisableDeepCopy is combined via precedence. Only if a value for a particular GVK is unset in the specified options will a value from the inherited options be used. - Transform functions are combined via chaining. If both inherited and specified options define a transform function, the transform function from the inherited options will be called first, and the transform function from the specified options will be called second. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
fix-cache-inheritance
branch
from
b0184e1
to
b38c4a5
Compare
|
/retest |
|
/retest /lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
Oh wasn't aware self-approve is enabled in this repo. Sorry if this wasn't intended to be merged already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using cache.BuilderWithOptions does not properly inherit all
options passed in from the caller:
selectors remained unset
transforms remained unset
specified options for disabling deep copies remained unset
This commit resolves this issues by implementing merge logic for all
fields in the cache.Options struct:
options if left unset in specified options
options if left unset in specified options
options if left unset in specified options
selectors for a given type, those selectors are merged via logical
AND.
particular GVK is unset in the specified options will a value from the
inherited options be used.
specified options define a transform function, the transform function
from the inherited options will be called first, and the transform
function from the specified options will be called second.
This is a breaking change if your code does all of the following:
cache.BuilderWithOptionscache.BuilderWithOptions.Signed-off-by: Joe Lanford joe.lanford@gmail.com