Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump k8s v0.25.0-alpha.3 #1967

Merged
merged 1 commit into from Aug 8, 2022

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Aug 2, 2022

Signed-off-by: jesus m. rodriguez jesusr@redhat.com

Fixes: #1966

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2022
@joelanford
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@joelanford
Copy link
Member

/approve cancel

Ping me again when the tests are passing and I'll take another look!

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@jmrodri
Copy link
Contributor Author

jmrodri commented Aug 3, 2022

@joelanford oof sorry didn't see they were failing. I ran them locally. I'll investigate them.

@jmrodri
Copy link
Contributor Author

jmrodri commented Aug 5, 2022

/retest

@jmrodri
Copy link
Contributor Author

jmrodri commented Aug 5, 2022

@joelanford @camilamacedo86 tests passed

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

@camilamacedo86
Copy link
Member

Adding the label since it was aproved/lgtm already and the issue was a flake in the ci.

@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: camilamacedo86, jmrodri, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bcde6f0 into kubernetes-sigs:master Aug 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump k8s to Kubernetes v1.25.0-alpha.3
5 participants