⚠️ Do not mutate the global warning handler #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only configure the local warning handler.
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
varshaprasad96
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Based on the discussion in #1928, the fix seems reasonable.
/lgtm
k8s-ci-robot
added
the
lgtm
|
@ash2k the change seems fine but can you please mark it as breaking, since that is what it is now, for better or worse? |
ash2k
changed the title
|
@alvaroaleman Changed the title if that was what you meant (not sure). Thanks for a quick review, appreciate it! |
alvaroaleman
approved these changes
Jun 29, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, ash2k, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only configure the local warning handler. Please see the issue for details.
Fixes #1928.