Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix issue with starting multiple test envs #1910

Merged
merged 1 commit into from May 24, 2022
Merged

🐛 Fix issue with starting multiple test envs #1910

merged 1 commit into from May 24, 2022

Conversation

jcanseco
Copy link
Contributor

Fixes #1909

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 18, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jcanseco / name: Jazel Canseco (2bf4851)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 18, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @jcanseco!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 18, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jcanseco. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 18, 2022
@jcanseco jcanseco changed the title Fix bug that can occur when starting multiple test environments in parallel 🐛 🐛 Fix bug that can occur when starting multiple test environments in parallel May 18, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 18, 2022
@jcanseco
Fix issue with starting multiple test envs
81e2eb1 
When starting a single test environment [1], the control plane start-up
logic [2] launches an etcd and kube-apiserver process. The start-up
logic needs to bind these processes to multiple ports, and when none are
configured in advance, the logic looks for unused ports, and then
creates files in the user cache directory to reserve them (for example,
[3]).

However, the same logic used to reserve ports  also has logic that
deletes files corresponding to "outdated" ports [4].

Therefore, if there are multiple processes/threads starting a test
environment, they may sometimes end up trying to delete the same file
which causes a "file not found" error.

This commit adds logic so that trying to start multiple test
environments does not fail if more than one tries to delete the same
file corresponding to an outdated port.

[1] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/envtest/server.go#L197
[2] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/controlplane/plane.go#L49
[3] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/controlplane/etcd.go#L120
[4] https://github.com/kubernetes-sigs/controller-runtime/blob/7fb8534b80339a5b8158cee3dc9e5f9439d679dc/pkg/internal/testing/addr/manager.go#L64
@jcanseco jcanseco changed the title 🐛 Fix bug that can occur when starting multiple test environments in parallel 🐛 Fix issue with starting multiple test envs May 18, 2022
@jcanseco
Copy link
Contributor Author

I think this should be ready for review now. Please let me know if I missed anything else.

@varshaprasad96
Copy link
Member

/ok-to-test
@jcanseco thanks for the PR, I think this does seem to be good.
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2022
@jcanseco
Copy link
Contributor Author

Thank you!

/assign @apelisse

@jcanseco
Copy link
Contributor Author

/assign @apelisse

alvaroaleman
alvaroaleman approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcanseco thank you!

If possible, please add the commit description to the PR body next time.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, jcanseco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4e6a39f into kubernetes-sigs:master May 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.10.x milestone May 24, 2022
@jcanseco
Copy link
Contributor Author

Thank you! Do we know when this PR will be released?

@alvaroaleman
Copy link
Member

I can cherrypick it onto the release branch for you, but we do not currently have a formalized release cadence

/cherrypick release-0.12

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 24, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@alvaroaleman: new pull request created: #1913

In response to this:

I can cherrypick it onto the release branch for you, but we do not currently have a formalized release cadence

/cherrypick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcanseco
Copy link
Contributor Author

Awesome, thank you! That would be quite helpful for us as this issue has been causing fairly frequent test flakes for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@apelisse apelisse

@alvaroaleman alvaroaleman

@varshaprasad96 varshaprasad96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10.x
Development

Successfully merging this pull request may close these issues.

Starting multiple test environments can fail due to multiple trying to delete the same port file
6 participants
@jcanseco @k8s-ci-robot @varshaprasad96 @alvaroaleman @k8s-infra-cherrypick-robot @apelisse