Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Upgrade k8s dependencies from 1.23.0 to 1.23.5 #1853

Merged
merged 1 commit into from Mar 30, 2022
Merged

✨Upgrade k8s dependencies from 1.23.0 to 1.23.5 #1853

merged 1 commit into from Mar 30, 2022

Conversation

NikhilSharmaWe
Copy link
Member

This Bumps all k8s dependencies.
PR was made for Bumping k8s 1.23.3 to get bug fixes in kubernetes-sigs/kubebuilder kubernetes-sigs/kubebuilder#2502, these changes are required before we can do that.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2022
@alvaroaleman alvaroaleman changed the base branch from master to release-0.11 March 29, 2022 18:27
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2022
@alvaroaleman alvaroaleman added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2022
@alvaroaleman alvaroaleman reopened this Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 29, 2022 •
edited

@NikhilSharmaWe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-test-master b49d49f link true /test pull-controller-runtime-test-master
pull-controller-runtime-apidiff-master b49d49f link false /test pull-controller-runtime-apidiff-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alvaroaleman
Copy link
Member

/skip

@NikhilSharmaWe
Copy link
Member Author

NikhilSharmaWe commented Mar 29, 2022 •
edited

@alvaroaleman I am not very sure about how to make a PR for cherry picking the changes made in this #1843 PR. Is this correct method, I have not made a cherry-pick PR against a release manually. When I made this PR automatically some other commits were also added in this PR, I do not know whether it is expected or not.

@alvaroaleman
Copy link
Member

They were added because you created the PR against the wrong branch, master instead of 0.11. Please run go mod tidy to get the go,sum file fixed up

@sbueringer sbueringer mentioned this pull request Mar 29, 2022
Merged
@NikhilSharmaWe
Copy link
Member Author

@alvaroaleman Just pinging that PR is ready to be merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit bf71fc5 into kubernetes-sigs:release-0.11 Mar 30, 2022
@NikhilSharmaWe NikhilSharmaWe mentioned this pull request Mar 30, 2022
Closed
fabianvf pushed a commit to fabianvf/controller-runtime that referenced this pull request May 25, 2022
@NikhilSharmaWe @fabianvf
Upgrade k8s dependencies from 1.23.0 to 1.23.5 (kubernetes-sigs#1853)
5e0af33
Oilysxewe204
Oilysxewe204 reviewed Jul 20, 2022
View reviewed changes
Copy link

@Oilysxewe204 Oilysxewe204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://twitter.com/Oilysxewe204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oilysxewe204 Oilysxewe204 Oilysxewe204 left review comments

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NikhilSharmaWe @k8s-ci-robot @alvaroaleman @Oilysxewe204