Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [release-0.11] Fixed a bug in newGVKFixupWatcher which caused the metadata informer to hang #1801

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #1790

/assign joelanford

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2022
@joelanford joelanford changed the title [release-0.11] 🐛 Fixed a bug in newGVKFixupWatcher which caused the metadata informer to hang 🐛 [release-0.11] Fixed a bug in newGVKFixupWatcher which caused the metadata informer to hang Feb 10, 2022
@joelanford
Copy link
Member

/hold

We need to add prow configuration for the release-0.11 branch.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2022
@joelanford
Copy link
Member

Submitted kubernetes/test-infra#25205 to add presubmit jobs for the 0.11 branch. Once that merges, I'll close/re-open this PR to trigger those jobs.

@joelanford joelanford closed this Feb 10, 2022
@joelanford joelanford reopened this Feb 10, 2022
@joelanford
Copy link
Member

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@wallrj
Copy link
Contributor

wallrj commented Feb 10, 2022

I'm not sure whether it matters, but the original PR had the label tide/merge-method-squash

@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6627ea2 into kubernetes-sigs:release-0.11 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants