🌱 Remove async ginkgo tests #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/test pull-controller-runtime-test-master |
|
/retest |
Do you have a link for that? |
Ginkgo has deprecated async tests with channels, and given that we're not really using those properly or consistently, remove them from controller runtime and simplify our tests. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
remove-async-ginkgo
branch
from
8736073
to
1f32e46
Compare
alvaroaleman
approved these changes
Jun 23, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nabil372
pushed a commit
to gocardless/theatre
that referenced
this pull request
Nov 15, 2022
Removed deprecated async Ginkgo tests. Also following the example of controller-runtime: kubernetes-sigs/controller-runtime#1564
Nabil372
pushed a commit
to gocardless/theatre
that referenced
this pull request
Nov 30, 2022
Removed deprecated async Ginkgo tests. Also following the example of controller-runtime: kubernetes-sigs/controller-runtime#1564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ginkgo has deprecated async tests with channels, and given that we're
not really using those properly or consistently, remove them from
controller runtime and simplify our tests.
Signed-off-by: Vince Prignano vincepri@vmware.com