✨ Structured args in Testing #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
DirectXMan12
force-pushed
the
feature/testing-structured-args
branch
from
a0649c7
to
e3b6d3c
Compare
This should make it a bit easier to manage argument overrides than the
set of templates we have now, especially while we wait for
componentconfig to be everywhere.
Arguments can be defaulted, and those defaults can be overriden or
appended to, and then finally render to a slice of strings to be passed
as arguments and such.
This should make it easier to configure the API server without needing
to splat out the existing default arguments, maybe splice some stuff
out, etc.
For example:
```go
apiServer.Configure().
Disable("insecure-port").
Append("vmodule", "httplog.go=10").
Set("v", "5")
```
This converts the internal testing package to use structured arguments, introducing a new helper to preserve compat when specifying legacy args.
DirectXMan12
force-pushed
the
feature/testing-structured-args
branch
from
e3b6d3c
to
ddfdfdf
Compare
k8s-ci-robot
added
size/XL
vincepri
approved these changes
May 26, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds structured arguments to the testing package, deprecating the old style where we do templating in favor of a fluent API with defaults that can be overridden.
This should make it easier for consumers to override individual arguments while not breaking the necessary flags that are required for the API server to function, and should make it easier for us to deal with upcoming changes in the k8s API server that requiring setting flags in some conditions, but not in others that are unrelated to the value of the flag (e.g. certain flags must be passed for older versions, but must NOT be passed for newer versions).
The new API looks roughly like:
There's also a helper to merge the new arguments with the older style ones. To preserve existing behavior, if the end user explicitly passes a template, we'll consider those to be the "defaults", otherwise we'll use our normal new default logic.
Depends on #1540
Part of #1486