✨ pkg/log/zap: clarify zap level vs. logr verbosity #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
size/M
coderanger
reviewed
Apr 19, 2021
pkg/log/zap/zap.go
Outdated
| // Level sets the the minimum enabled logging level e.g Debug, Info | ||
| // See Options.Level | ||
| // Level sets Options.Level, which configures the the minimum enabled logging level e.g Debug, Info. | ||
| // If using zapcore.Level(N), where N > 0, set zapcore.Level(-1*N) instead. |
There was a problem hiding this comment.
This line feels confusing, I think you mean the second bit to be Level(-1*N) for how to call this function? Or the first?
There was a problem hiding this comment.
Lmk if my update makes more sense.
kensipe
approved these changes
Apr 19, 2021
…xplanation and test cases Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
|
/test pull-controller-runtime-test-master |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, estroz, kensipe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies zap level vs. logr verbosity with a link to the zapr explanation of this difference, and test cases.
/kind documentation
Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com