Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 fix DestWritter var name typo #1340

Merged
merged 1 commit into from Jan 21, 2021

Conversation

nader-ziada
Copy link
Contributor

  • change name of var from DestWritter to DestWriter

Fixes: #1294

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2021
@coderanger
Copy link
Contributor

This lost another t, is that intentional?

@nader-ziada
Copy link
Contributor Author

This lost another t, is that intentional?

This was the issue, to replace Writter with Writer to correct the spelling of it

@coderanger
Copy link
Contributor

Yes but you changed Dest to Des too.

@nader-ziada
Copy link
Contributor Author

Yes but you changed Dest to Des too.

Oh sorry. That's by mistake, will fix it.

@coderanger
Copy link
Contributor

I defer to others if this is worth fixing with a compat break. The field probably isn't used a ton or we would have noticed this sooner? If we want compat, a more complex fix will be needed.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2021
@nader-ziada
Copy link
Contributor Author

I defer to others if this is worth fixing with a compat break. The field probably isn't used a ton or we would have noticed this sooner? If we want compat, a more complex fix will be needed.

/lgtm

its fine if we don't need it, I can close the PR, was just trying to find an easy first PR to do to get familiar with the repo

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be to add a new DestWriter field, deprecate the misspelled one, and do whatever is necessary to ensure they鈥檙e interchangeable (preferring DestWriter if they鈥檙e both set), and then remove DestWritter in a later release?

@nader-ziada
Copy link
Contributor Author

How hard would it be to add a new DestWriter field, deprecate the misspelled one, and do whatever is necessary to ensure they鈥檙e interchangeable (preferring DestWriter if they鈥檙e both set), and then remove DestWritter in a later release?

should not be too hard, will work on that and update PR, thanks

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2021
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misspelling 'DestWritter'
6 participants