✨ Manager: Start all caches before other Runnables #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
force-pushed
the
start-clusters
branch
from
c9b52c6
to
8e59887
Compare
|
/retest |
This pr implements the second half of the ["Move cluster-specific code out of the manager" proposal][0]: Making it start all caches before other Runnables and not just the one of the main Cluster. [0]: https://github.com/kubernetes-sigs/controller-runtime/blob/66537ca5b7439b06f2f3b08901640f934834c9a1/designs/move-cluster-specific-code-out-of-manager.md#L131-L132
alvaroaleman
force-pushed
the
start-clusters
branch
from
8e59887
to
70df377
Compare
|
/assign @vincepri |
vincepri
approved these changes
Jan 21, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Closed
Closed
vgramer
added a commit
to vgramer/kubermatic
that referenced
this pull request
Mar 1, 2022
since controller-runtime v0.8.1, manager start all caches before other Runnables so this function is not need anymore cf kubernetes-sigs/controller-runtime#1327 Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
kubermatic-bot
pushed a commit
to kubermatic/kubermatic
that referenced
this pull request
Mar 1, 2022
… controllers (#9168) * remove function util.IsCacheNotStarted since controller-runtime v0.8.1, manager start all caches before other Runnables so this function is not need anymore cf kubernetes-sigs/controller-runtime#1327 Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/usersshkeyssynchronizer/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/project-label-synchronizer/project_label_synchronizer.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/master-constraint-template-controller/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/master-constraint-controller/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com> * master-controller-manager/cluster-template-synchronizer/controller.go: remove unecessary check since controller-runtime v0.8.1 the manager start all cache before running runables, so this error can not happen. Signed-off-by: Vincent Gramer <vincent@kubermatic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements the second half of the "Move cluster-specific code
out of the manager" proposal: Making it start all caches before other
Runnables and not just the one of the main Cluster.