馃悰 ignore namespace key when getting cluster-scoped resources #1326
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/retest |
| By("listing all namespaces - should still be able to get a cluster-scoped resource") | ||
| namespaceList := &unstructured.UnstructuredList{} | ||
| namespaceList.SetGroupVersionKind(schema.GroupVersionKind{ | ||
| By("listing all nodes - should still be able to list a cluster-scoped resource") |
There was a problem hiding this comment.
Why did you change this from Namespace to Node?
There was a problem hiding this comment.
Mainly to avoid confusion of trying to explain "setting a namespace key on a namespace"
pkg/cache/cache_test.go
Outdated
| namespaceList := &unstructured.UnstructuredList{} | ||
| namespaceList.SetGroupVersionKind(schema.GroupVersionKind{ | ||
| By("listing all nodes - should still be able to list a cluster-scoped resource") | ||
| nodeList := &kmetav1.PartialObjectMetadataList{} |
There was a problem hiding this comment.
This needs to remain an unstructured.UnstructuredList, otherwise the two testcases are identical
There was a problem hiding this comment.
Good catch! That was an accidental copy/paste error.
joelanford
force-pushed
the
bug/ignore-namespace-cluster-scoped-get
branch
from
90d071d
to
f6f9ff4
Compare
joelanford
force-pushed
the
bug/ignore-namespace-cluster-scoped-get
branch
from
f6f9ff4
to
2c0bd8f
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR makes the controller-runtime cache consistent with the behavior of the client when working with cluster-scoped resources.
Closes #1323
Current behavior:
When fetching a cluster-scoped resource using a direct client (e.g.
mgr.GetAPIReader), the namespace in the object key is ignored. When fetching a cluster-scoped resource via the cache, the namespace key MUST be set to an empty string. Otherwise the cache will return a not found error.Expected behavior:
When fetching a cluster-scoped resource via the cache, the namespace key is ignored, just like with a direct client. The APIReader and Cache behavior should be consistent.