✨ initialize reconciler metrics when controller is started #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/test pull-controller-runtime-test-master |
1 similar comment
|
/test pull-controller-runtime-test-master |
joelanford
force-pushed
the
feature/init-metrics
branch
from
7b33fea
to
fc11162
Compare
joelanford
force-pushed
the
feature/init-metrics
branch
from
fc11162
to
acbdf64
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initializes the known reconciler metrics for a controller when the controller starts up (rather than waiting for a reconciliation to happen).
While there are ways with promql to work around missing metrics like this, it is a prometheus best practice to initialize all known metrics in advance. See: https://prometheus.io/docs/practices/instrumentation/#avoid-missing-metrics
Issue first reported here: operator-framework/operator-sdk#4372