Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Bump k8s dependencies to 1.20 #1268

Merged
merged 1 commit into from Dec 15, 2020
Merged

✨ Bump k8s dependencies to 1.20 #1268

merged 1 commit into from Dec 15, 2020

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Nov 17, 2020 •
edited

Bump k8s dependencies to 1.20

Update: Updated the PR to use k8s 1.20.
Note: This PR currently bumps the Kubernetes dependencies to v1.20.0-beta.1 release. This will be updated once a stable 1.20 release is out.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @varshaprasad96. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2020
@varshaprasad96 varshaprasad96 changed the title (:sparkles, minor) Bump k8s dependencies to 1.20 (:sparkles:) Bump k8s dependencies to 1.20 Nov 17, 2020
@varshaprasad96 varshaprasad96 mentioned this pull request Nov 17, 2020
Closed
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2020
@joelanford
Copy link
Member

/hold

Until v0.7.0 is released.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2020
@joelanford
Copy link
Member

/retitle ✨ Bump k8s dependencies to 1.20

@k8s-ci-robot k8s-ci-robot changed the title (:sparkles:) Bump k8s dependencies to 1.20 ✨ Bump k8s dependencies to 1.20 Nov 17, 2020
@estroz estroz mentioned this pull request Dec 2, 2020
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2020
@estroz
Copy link
Contributor

estroz commented Dec 11, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2020
@estroz
Copy link
Contributor

estroz commented Dec 14, 2020

@vincepri @alvaroaleman @DirectXMan12 can we get this reviewed/merged then cut v0.8.0 this week?

alvaroaleman
alvaroaleman approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@estroz
Copy link
Contributor

estroz commented Dec 15, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 280bb8a into kubernetes-sigs:master Dec 15, 2020
@tamalsaha tamalsaha mentioned this pull request Dec 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@varshaprasad96 @k8s-ci-robot @camilamacedo86 @joelanford @estroz @alvaroaleman