Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and looking for envtest bins in the $GOBIN/ by default #1234

Closed
camilamacedo86 opened this issue Oct 31, 2020 · 5 comments
Closed

Install and looking for envtest bins in the $GOBIN/ by default #1234

camilamacedo86 opened this issue Oct 31, 2020 · 5 comments
Assignees
Labels
kind/breaking-change lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented Oct 31, 2020

Description

Currently, the default path where controller-runtime is looking for the binaries which are required for the env tests is "/usr/local/kubebuilder/bin". See: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/envtest/server.go#L57

This issue is to purpose the idea of:

Motivation

@estroz
Copy link
Contributor

estroz commented Dec 15, 2020

Expanding on this: it would be nice to have

  • a set of simple loading rules (like with kubeconfigs)
  • a helper to install envtest binaries to one of those locations
  • a helper to compare binary versions

@camilamacedo86
Copy link
Member Author

We might consider addressing these requirements toghether with #1300.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 20, 2021
@DirectXMan12
Copy link
Contributor

I think this is likely to be subsumed by #1488, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking-change lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants