From 07ba0bce56f4a3ff7cd0ae899e6976fa3f51e4d0 Mon Sep 17 00:00:00 2001 From: Tomy GUICHARD Date: Mon, 8 Aug 2022 18:41:24 +0200 Subject: [PATCH] Fix panic in conversion webhook --- pkg/webhook/conversion/conversion.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/webhook/conversion/conversion.go b/pkg/webhook/conversion/conversion.go index a5b7a282ce..879aae3c9b 100644 --- a/pkg/webhook/conversion/conversion.go +++ b/pkg/webhook/conversion/conversion.go @@ -69,6 +69,12 @@ func (wh *Webhook) ServeHTTP(w http.ResponseWriter, r *http.Request) { return } + if convertReview.Request == nil { + log.Error(nil, "conversion request is nil") + w.WriteHeader(http.StatusBadRequest) + return + } + // TODO(droot): may be move the conversion logic to a separate module to // decouple it from the http layer ? resp, err := wh.handleConvertRequest(convertReview.Request)