/
webhook_test.go
232 lines (192 loc) · 6.73 KB
/
webhook_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
/*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package admission
import (
"context"
"net/http"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
jsonpatch "gomodules.xyz/jsonpatch/v2"
admissionv1 "k8s.io/api/admission/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
machinerytypes "k8s.io/apimachinery/pkg/types"
logf "sigs.k8s.io/controller-runtime/pkg/internal/log"
"sigs.k8s.io/controller-runtime/pkg/runtime/inject"
)
var _ = Describe("Admission Webhooks", func() {
allowHandler := func() *Webhook {
handler := &fakeHandler{
fn: func(ctx context.Context, req Request) Response {
return Response{
AdmissionResponse: admissionv1.AdmissionResponse{
Allowed: true,
},
}
},
}
webhook := &Webhook{
Handler: handler,
log: logf.RuntimeLog.WithName("webhook"),
}
return webhook
}
It("should invoke the handler to get a response", func() {
By("setting up a webhook with an allow handler")
webhook := allowHandler()
By("invoking the webhook")
resp := webhook.Handle(context.Background(), Request{})
By("checking that it allowed the request")
Expect(resp.Allowed).To(BeTrue())
})
It("should ensure that the response's UID is set to the request's UID", func() {
By("setting up a webhook")
webhook := allowHandler()
By("invoking the webhook")
resp := webhook.Handle(context.Background(), Request{AdmissionRequest: admissionv1.AdmissionRequest{UID: "foobar"}})
By("checking that the response share's the request's UID")
Expect(resp.UID).To(Equal(machinerytypes.UID("foobar")))
})
It("should populate the status on a response if one is not provided", func() {
By("setting up a webhook")
webhook := allowHandler()
By("invoking the webhook")
resp := webhook.Handle(context.Background(), Request{})
By("checking that the response share's the request's UID")
Expect(resp.Result).To(Equal(&metav1.Status{Code: http.StatusOK}))
})
It("shouldn't overwrite the status on a response", func() {
By("setting up a webhook that sets a status")
webhook := &Webhook{
Handler: HandlerFunc(func(ctx context.Context, req Request) Response {
return Response{
AdmissionResponse: admissionv1.AdmissionResponse{
Allowed: true,
Result: &metav1.Status{Message: "Ground Control to Major Tom"},
},
}
}),
log: logf.RuntimeLog.WithName("webhook"),
}
By("invoking the webhook")
resp := webhook.Handle(context.Background(), Request{})
By("checking that the message is intact")
Expect(resp.Result).NotTo(BeNil())
Expect(resp.Result.Message).To(Equal("Ground Control to Major Tom"))
})
It("should serialize patch operations into a single jsonpatch blob", func() {
By("setting up a webhook with a patching handler")
webhook := &Webhook{
Handler: HandlerFunc(func(ctx context.Context, req Request) Response {
return Patched("", jsonpatch.Operation{Operation: "add", Path: "/a", Value: 2}, jsonpatch.Operation{Operation: "replace", Path: "/b", Value: 4})
}),
log: logf.RuntimeLog.WithName("webhook"),
}
By("invoking the webhook")
resp := webhook.Handle(context.Background(), Request{})
By("checking that a JSON patch is populated on the response")
patchType := admissionv1.PatchTypeJSONPatch
Expect(resp.PatchType).To(Equal(&patchType))
Expect(resp.Patch).To(Equal([]byte(`[{"op":"add","path":"/a","value":2},{"op":"replace","path":"/b","value":4}]`)))
})
Describe("dependency injection", func() {
It("should set dependencies passed in on the handler", func() {
By("setting up a webhook and injecting it with a injection func that injects a string")
setFields := func(target interface{}) error {
inj, ok := target.(stringInjector)
if !ok {
return nil
}
return inj.InjectString("something")
}
handler := &fakeHandler{}
webhook := &Webhook{
Handler: handler,
log: logf.RuntimeLog.WithName("webhook"),
}
Expect(setFields(webhook)).To(Succeed())
Expect(inject.InjectorInto(setFields, webhook)).To(BeTrue())
By("checking that the string was injected")
Expect(handler.injectedString).To(Equal("something"))
})
It("should inject a decoder into the handler", func() {
By("setting up a webhook and injecting it with a injection func that injects a scheme")
setFields := func(target interface{}) error {
if _, err := inject.SchemeInto(runtime.NewScheme(), target); err != nil {
return err
}
return nil
}
handler := &fakeHandler{}
webhook := &Webhook{
Handler: handler,
log: logf.RuntimeLog.WithName("webhook"),
}
Expect(setFields(webhook)).To(Succeed())
Expect(inject.InjectorInto(setFields, webhook)).To(BeTrue())
By("checking that the decoder was injected")
Expect(handler.decoder).NotTo(BeNil())
})
It("should pass a setFields that also injects a decoder into sub-dependencies", func() {
By("setting up a webhook and injecting it with a injection func that injects a scheme")
setFields := func(target interface{}) error {
if _, err := inject.SchemeInto(runtime.NewScheme(), target); err != nil {
return err
}
return nil
}
handler := &handlerWithSubDependencies{
Handler: HandlerFunc(func(ctx context.Context, req Request) Response {
return Response{}
}),
dep: &subDep{},
}
webhook := &Webhook{
Handler: handler,
}
Expect(setFields(webhook)).To(Succeed())
Expect(inject.InjectorInto(setFields, webhook)).To(BeTrue())
By("checking that setFields sets the decoder as well")
Expect(handler.dep.decoder).NotTo(BeNil())
})
})
})
var _ = Describe("Should be able to write/read admission.Request to/from context", func() {
ctx := context.Background()
testRequest := Request{
admissionv1.AdmissionRequest{
UID: "test-uid",
},
}
ctx = NewContextWithRequest(ctx, testRequest)
gotRequest, err := RequestFromContext(ctx)
Expect(err).To(Not(HaveOccurred()))
Expect(gotRequest).To(Equal(testRequest))
})
type stringInjector interface {
InjectString(s string) error
}
type handlerWithSubDependencies struct {
Handler
dep *subDep
}
func (h *handlerWithSubDependencies) InjectFunc(f inject.Func) error {
return f(h.dep)
}
type subDep struct {
decoder *Decoder
}
func (d *subDep) InjectDecoder(dec *Decoder) error {
d.decoder = dec
return nil
}