Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Support any controlplane that implements rolloutAfter in it's spec with clusterctl alpha rollout #10648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Support any controlplane that implements rolloutAfter in it's spec with clusterctl alpha rollout #10648

wants to merge 1 commit into from

Conversation

wikoion
Copy link

@wikoion wikoion commented May 20, 2024

What this PR does / why we need it:
Modify clusterctl alpha rollout to support any controlplane.cluster.x-k8s.io and also support different api versions e.g.
clusterctl alpha rollout restart kthreescontrolplane.controlplane.cluster.x-k8s.io.v1beta2/my-kcp if the version is ommitted then the default of v1beta1 will be used.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10621

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label May 20, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 20, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wikoion / name: Richard Draycott (ff0507e)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @wikoion. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wikoion wikoion force-pushed the wikoion/polymorphic-alpha-rollout branch 5 times, most recently from 8e5c8ae to 2c03019 Compare May 20, 2024 15:20
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 20, 2024
@wikoion
✨ Change clusterctl alpha rollout to support any controlplane that im…
ff0507e 
…plements rolloutAfter in it's spec

Signed-off-by: Richard Draycott <wikoion@draycott.live>
@wikoion wikoion force-pushed the wikoion/polymorphic-alpha-rollout branch from 2c03019 to ff0507e Compare May 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees
No one assigned
Labels
area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support clusterctl alpha rollout kthreescontrolplane/...
2 participants
@wikoion @k8s-ci-robot