Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AAD extensions for VMSS in AKS created by Cluster API #4701

Open
mani3887 opened this issue Apr 4, 2024 · 5 comments
Open

Adding AAD extensions for VMSS in AKS created by Cluster API #4701

mani3887 opened this issue Apr 4, 2024 · 5 comments
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@mani3887
Copy link

mani3887 commented Apr 4, 2024

What steps did you take and what happened?

We created a AKS cluster using Cluster API. Recently we tried adding AAD plugins on our VMSS. It was added successfully, but it was removed after few mins. We suspect this is happening because some other configuration is overwriting this and we suspect that this could be because of CapZ. When we inspect the CapZ azure machine pools, we do not see a spec for extensions. Can you please let us know whether this could be because of an incorrect configuration on CapZ?

What did you expect to happen?

AAD extensions getting added successfully in VMSS pools.

Cluster API version

https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api/cluster.x-k8s.io/MachinePool/v1beta1@v1.3.2

Kubernetes version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

CAPI contributors will take a look as soon as possible, apply one of the triage/* labels and provide further guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

Heyho,
I'll move this issue to CAPZ

/transfer cluster-api-provider-azure

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes-sigs/cluster-api Apr 4, 2024
@jackfrancis
Copy link
Contributor

@mani3887 are the AAD extensions an AKS configuration (i.e., a configuration against an "agentPoolProfile"), or is this a VMSS-specific extension that you add after cluster creation to the VMSS in the "MC_" resource group?

@mani3887
Copy link
Author

@jackfrancis : Thanks for your response. This is for Azure VMSS specific extension that we need to add after the cluster creation.
This is a self managed cluster created by Cluster API. We do not have the MC_resource group(as I have seen while creating AKS as a service). We have already created the cluster using Cluster API. On researching the cluster API -https://capz.sigs.k8s.io/topics/custom-vm-extensions, I saw there was a provision for configuring the AAD VM extensions, something like this on the azure machine pool:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: AzureMachinePool
spec:
template:
vmExtensions:
- name: AADSSHLoginForLinux
publisher: Microsoft.Azure.ActiveDirectory
version: '1.0.2644.1'

@willie-yao
Copy link
Contributor

On researching the cluster API -https://capz.sigs.k8s.io/topics/custom-vm-extensions, I saw there was a provision for configuring the AAD VM extensions, something like this on the azure machine pool:

Did specifying the AAD VM extension fix the problem, or is it still being overwritten? Specifying the extension in the spec should do the trick.

@dtzar dtzar added the area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/managedclusters Issues related to managed AKS clusters created through the CAPZ ManagedCluster Type kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: No status
Development

No branches or pull requests

6 participants