Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate duplicate webhook logic for managed cluster types #4530

Open
nojnhuh opened this issue Feb 1, 2024 · 2 comments
Open

Consolidate duplicate webhook logic for managed cluster types #4530

nojnhuh opened this issue Feb 1, 2024 · 2 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 1, 2024

/kind cleanup

What needs cleanup:
[A clear and concise description of what needs to be cleaned up.]

Currently, the same logic is duplicated in both the template and non-template webhooks for AzureManaged* resources:

setDefault[*string](&mcp.Spec.Template.Spec.NetworkPlugin, ptr.To(AzureNetworkPluginName))

setDefault[*string](&m.Spec.NetworkPlugin, ptr.To(AzureNetworkPluginName))

Describe the solution you'd like

The webhooks for AzureManaged* resources should follow the same pattern as the self-managed cluster types to avoid duplication.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 1, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Feb 1, 2024

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Feb 1, 2024
@nojnhuh nojnhuh modified the milestones: v1.14, next Feb 29, 2024
@mboersma mboersma modified the milestones: next, v1.15 Mar 13, 2024
@mboersma
Copy link
Contributor

/milestone next

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.15, next Apr 25, 2024
@dtzar dtzar removed this from the next milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Status: Todo
Development

No branches or pull requests

4 participants