Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump golangci-lint version #608

Merged
merged 3 commits into from Nov 2, 2022
Merged

chore: Bump golangci-lint version #608

merged 3 commits into from Nov 2, 2022

Conversation

rquitales
Copy link
Contributor

@rquitales rquitales commented Nov 1, 2022 •
edited

This commit bumps golangci-lint to v1.50.0 as the older version has memory issues that causes presubmits to time out.

@rquitales
chore: Bump golangci-lint version
31fa3de 
This commit bumps golangci-lint to v1.5.0 as the older version has
memory issues that causes presubmits to time out.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rquitales. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2022
@rquitales
Copy link
Contributor Author

/cc @karlkfi

karlkfi
karlkfi approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@karlkfi karlkfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2022
@rquitales
refactor: Fix linting issues found in golangci-lint v1.50.0
c494d01
@rquitales
chore: Remove deprecated linters
49981f7 
`varcheck`, `structcheck` and `deadcode` were deprecated in 2021. This
commit removes them. Their functionality is provided by the `unused`
linter.

See: golangci/golangci-lint#1841
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2022
@rquitales rquitales mentioned this pull request Nov 1, 2022
Merged
@karlkfi
Copy link
Contributor

karlkfi commented Nov 1, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2022
karlkfi
karlkfi reviewed Nov 2, 2022
View reviewed changes
.golangci.yml
@@ -10,7 +10,6 @@ linters:
disable-all: true
enable:
- bodyclose
- deadcode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these 3 checkers removed?

karlkfi
karlkfi approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@karlkfi karlkfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, rquitales

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 57ba470 into kubernetes-sigs:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlkfi karlkfi karlkfi approved these changes

@haiyanmeng haiyanmeng Awaiting requested review from haiyanmeng

@seans3 seans3 Awaiting requested review from seans3

Assignees

@karlkfi karlkfi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rquitales @k8s-ci-robot @karlkfi