Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert use of upstream yaml parsing #455

Merged
merged 1 commit into from May 4, 2022

Conversation

jyotimahapatra
Copy link
Contributor

We found that users have a dependency on an undocumented behavior of the permissive yaml library that was changed here.

Using a block like below caused the yaml parsing to fail the whole roleArn section. This is a contract change and should be done behind a feature flag . Any yaml value starting with { would cause the failure.
If not done, customers upgrading to the new server version would see mapping error when cache is lost on authenticato restart.

    - groups:
      - systems:master
      rolearn: arn:aws:iam::xxx:role/testrole
      username: {{SessionName}}

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyotimahapatra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from wongma7 May 4, 2022 00:18
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@jyotimahapatra
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 4, 2022
@wongma7
Copy link
Contributor

wongma7 commented May 4, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0a72c12 into kubernetes-sigs:release-0.5 May 4, 2022
@jyotimahapatra jyotimahapatra deleted the rev2 branch May 4, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants