Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes with patch release #440

Closed
edify42 opened this issue Mar 16, 2022 · 5 comments
Closed

Breaking changes with patch release #440

edify42 opened this issue Mar 16, 2022 · 5 comments

Comments

@edify42
Copy link

edify42 commented Mar 16, 2022

Hey Maintainers 馃憢

Bit of a funny one but I feel like such changes should be breaking and be reflected as such with a major release?

0221afb

No point being shy with version numbers!

For more context, I was running version 0.5.0 and a team mate was running 0.5.5 and we found though we had the same kube_config the latter would through the API error:

Error: UPGRADE FAILED: Kubernetes cluster unreachable: Get "https://our-cluster.aws-region.eks.amazonaws.com/version?timeout=32s": getting credentials: exec plugin is configured to use API version client.authentication.k8s.io/v1alpha1, plugin returned version client.authentication.k8s.io/v1beta1

@nckturner
Copy link
Contributor

Thanks for pointing this out, we will revert and bump the major version.

@nckturner
Copy link
Contributor

Sorry for the delay. So I think with #439, its no longer a breaking change and we don't need to bump the major version. I'm inclined to put out an v0.5.6 for that reason since there's only a handful of changes. LMK if anyone thinks differently.

@nckturner
Copy link
Contributor

I'll add that I would like to do a 1.0 release, but perhaps we can discuss it separately.

@edify42
Copy link
Author

edify42 commented Apr 5, 2022

Thanks for your response @nckturner :)

I'm currently stuck trying to figure out how to solve our macos issues as the EKS docs say we should continue to use v1alpha1 and the newly built (but still older than 0.5.2 versions of) aws-iam-authenticator binaries in the S3 bucket provided by the AWS docs throw this error on our systems:

./aws-iam-authenticator
fatal error: runtime: bsdthread_register error

Hence my annoyed tone 馃槄

Fortunately the Github releases have binaries that work on newer MacOS :)

@edify42
Copy link
Author

edify42 commented Apr 5, 2022

Thanks @wongma7 as well for reverting the commit. Looking forward to 0.5.6 馃帀

It's less of a headache for us now 馃憤

@edify42 edify42 closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants