Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Expose dnsConfig in Helm Chart for Custom DNS Configuration #1925

Closed
torredil opened this issue Feb 7, 2024 · 2 comments · Fixed by #2034
Closed

Feature Request: Expose dnsConfig in Helm Chart for Custom DNS Configuration #1925

torredil opened this issue Feb 7, 2024 · 2 comments · Fixed by #2034
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@torredil
Copy link
Member

torredil commented Feb 7, 2024

Is your feature request related to a problem? Please describe.

This feature request is motivated by issues faced during cluster scaling operations, where DNS throttling can lead to significant disruptions. Specifically, the controller can get throttled by EC2 security group connection tracking conntrack_allowance_exceeded_by_host due to excessive DNS queries.

Implementing a way to adjust controller pod DNS settings via the chart would offer a straightforward and generic solution to mitigate such issues.

Describe the solution you'd like in detail

A user should be able to configure DNS settings in the Helm chart values like so:

dnsConfig:
  options:
    - name: ndots
      value: "2"

The default ndots value is 5, which can lead to unnecessary DNS traffic and delays in resolving names. A value of 2 can be a good optimization for the scenario described above given the controller predominantly makes DNS queries to AWS endpoints or fully qualified domain names rather than in-cluster services.

Additional context

https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/

/feature

@torredil torredil added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 7, 2024
@r-yabyab
Copy link

r-yabyab commented May 5, 2024

/assign

@r-yabyab r-yabyab removed their assignment May 8, 2024
@omerap12
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants