Update dependency go modules for k8s v1.26.0 #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
size/XL
sunnylovestiramisu
force-pushed
the
module-update-master
branch
from
5329af9
to
3a2a001
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
added
size/XL
sunnylovestiramisu
force-pushed
the
module-update-master
branch
from
87ced66
to
eeda108
Compare
|
/assign @xing-yang |
xing-yang
reviewed
Dec 13, 2022
|
/release-note-none |
k8s-ci-robot
added
release-note-none
xing-yang
reviewed
Dec 13, 2022
sunnylovestiramisu
force-pushed
the
module-update-master
branch
from
eeda108
to
e0abaca
Compare
sunnylovestiramisu
force-pushed
the
module-update-master
branch
from
e0abaca
to
bb5a901
Compare
xing-yang
reviewed
Dec 14, 2022
sunnylovestiramisu
force-pushed
the
module-update-master
branch
from
fb3f750
to
e58d9d2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sunnylovestiramisu, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
xing-yang
reviewed
Dec 15, 2022
| @@ -31,11 +31,11 @@ require ( | |||
| github.com/pkg/errors v0.9.1 // indirect | |||
| github.com/spf13/pflag v1.0.5 // indirect | |||
| golang.org/x/mod v0.6.0 // indirect | |||
| golang.org/x/net v0.1.1-0.20221027164007-c63010009c80 // indirect | |||
| golang.org/x/net v0.3.1-0.20221206200815-1e63c2f08a10 // indirect | |||
There was a problem hiding this comment.
@sunnylovestiramisu Can you submit another PR to make a similar change in client/go.mod as follows:
replace golang.org/x/net => golang.org/x/net v0.4.0
I'm getting a dependencies change error when generating the changelog. I wonder if it is because the client and server go.mod are having different lib version.
k8s-ci-robot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.26.0
Does this PR introduce a user-facing change?: