Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting the _request_timeout parameter for the dynamic client #1732

Conversation

psontag
Copy link
Contributor

@psontag psontag commented Mar 1, 2022

What type of PR is this?

/feature

What this PR does / why we need it:

This PR adds support for the _request_timeout parameter to the dynamic client. The parameter can be passed to the dynamic clients requests method and is then passed on the api client.

Which issue(s) this PR fixes:

Fixes #1726

Special notes for your reviewer:

I am not sure how to properly test this change since I am new to the code base. Any hints would be appreciated.

Does this PR introduce a user-facing change?

The dynamic client now support the `_request_timeout` parameter to configure connection and request timeouts.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 1, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: philipp-sontag-by / name: philipp-sontag-by (6b8f241)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @philipp-sontag-by!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2022
@yliaog
Copy link
Contributor

yliaog commented Mar 2, 2022

please sign cla

@roycaihw
Copy link
Member

Is this still in draft state. Please let us know when it's ready for review. Thanks!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 20, 2022
@psontag psontag force-pushed the dynamic-client-request-timeout branch from 6b8f241 to 943b0e7 Compare April 20, 2022 08:23
@psontag
Copy link
Contributor Author

psontag commented Apr 20, 2022

Sorry for the delay here. I signed the CLA now and the PR is ready for review. Please let me know if you would like to have some tests for this change as well.

@psontag psontag marked this pull request as ready for review April 20, 2022 08:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
@psontag
Copy link
Contributor Author

psontag commented May 9, 2022

Hey @yliaog and @fabianvf,
I would appreciate a review here when you have some time.

@yliaog
Copy link
Contributor

yliaog commented May 9, 2022

/assign @fabianvf

Copy link
Contributor

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2022
@yliaog
Copy link
Contributor

yliaog commented May 9, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, philipp-sontag-by, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 38ba743 into kubernetes-client:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support request timeout in dynamic client
5 participants