-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Support setting the _request_timeout parameter for the dynamic client #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting the _request_timeout parameter for the dynamic client #1732
Conversation
|
Welcome @philipp-sontag-by! |
please sign cla |
Is this still in draft state. Please let us know when it's ready for review. Thanks! |
6b8f241
to
943b0e7
Compare
Sorry for the delay here. I signed the CLA now and the PR is ready for review. Please let me know if you would like to have some tests for this change as well. |
/assign @fabianvf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, philipp-sontag-by, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/feature
What this PR does / why we need it:
This PR adds support for the
_request_timeout
parameter to the dynamic client. The parameter can be passed to the dynamic clients requests method and is then passed on the api client.Which issue(s) this PR fixes:
Fixes #1726
Special notes for your reviewer:
I am not sure how to properly test this change since I am new to the code base. Any hints would be appreciated.
Does this PR introduce a user-facing change?