V1ServicePort with wrong type for targetPort

[Saeger]

Describe the bug
The "targetPort" type is defined as "object" while the possibility of values can be both number and string.
With this said, you can't set a type for a variable and fill targetPort with a number the way it's implemented.
"Type 'number' is not assignable to type 'object'.ts(2322)"

** Client Version **
0.14.3

** Server Version **
1.18.0

To Reproduce
Steps to reproduce the behavior:
Define a variable of type V1Service and try to make the specs for ports.

Expected behavior
The type definition could be defined as number | string since both are supported.

** Example Code**
ports: [ { name: 'http', port: 80, targetPort: 3000, protocol: 'TCP', }, ],

Environment (please complete the following information):

• OS: OSX
• NodeJS Version 14

[brendandburns]

Officially, the targetPort is an IntOrString so we need to implement special handlingwhich currently doesn't exist.

[Saeger]

@brendanburns where should I start looking and see if I could help with a fix ?

[brendandburns]

@Saeger thanks for offering to help.

We haven't done this for Javascript before, so it's likely to be a little rocky, but here's what (I think) you need to do.

We need to add typeMappings and importMappings, similar to this one in the Java client:
https://github.com/kubernetes-client/gen/blob/master/openapi/java.xml#L96

To the Javascript client config:
https://github.com/kubernetes-client/gen/blob/master/openapi/typescript.xml

Then you need to regenerate the client:
npm run generate

This code should not compile because it will be missing the IntOrString type, so then you'll need to add custom.ts (or somesuch) and define the IntOrString class in that file.

As I mentioned, complicated, please feel free to ping this issue if you try and see errors!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[brendandburns]

/lifecycle frozen

[alex-bezek]

@brendandburns thanks for pointing me to this issue, I've created a couple of pull requests which I think address the issue:

• Update typescript open API generator to handle the IntOrString type #741
• Update typescript open API generator to handle the IntOrString type gen#213

[brendandburns]

I have just pushed an 0.16.1 release to npm that contains a fix for IntOrString types. Many thanks to @alex-bezek for sending the PRs.