Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm request deprecated #634

Closed
regnaio opened this issue Apr 9, 2021 · 1 comment
Closed

npm request deprecated #634

regnaio opened this issue Apr 9, 2021 · 1 comment

Comments

@regnaio
Copy link

regnaio commented Apr 9, 2021

With request being deprecated (https://www.npmjs.com/package/request), I was wondering if there were plans to migrate to another library like got or axios?

I'm seeing errors sometimes from commands like k8sCoreV1Api.listNamespacedPod:

Error: getaddrinfo ENOTFOUND <URL>
      at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:69:26) {
    [stack]: 'Error: getaddrinfo ENOTFOUND <URL> at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:69:26)',
    [message]: 'getaddrinfo ENOTFOUND <URL>',
    errno: -3008,
    code: 'ENOTFOUND',
    syscall: 'getaddrinfo',
    hostname: '<URL>'
  }

I think this may be due to issues with Node and may be solved with HTTP Keep Alive, as mentioned in the article below:
https://medium.com/swlh/solving-node-dns-issues-and-other-things-5051d8526cac

The article mentions how HTTP Keep Alive is more easily used with libraries like got and not request, which is deprecated

Thanks!

@brendandburns
Copy link
Contributor

Duplicate of #414

@brendandburns brendandburns marked this as a duplicate of #414 Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants