Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderate Security Vulnerability as client uses depreciated Request library #1020

Closed
HedleyWard opened this issue Mar 23, 2023 · 3 comments
Closed

Comments

@HedleyWard
Copy link

Moderate Twistlock security scan failures in projects using @kubernetes/client-node

Looks like this module is using request module that has been deprecated over two years ago which now has security vulnerabilities.

Wondering if there is timeline to updating to newer library?

# npm audit report

request  *
Severity: moderate
Server-Side Request Forgery in Request - https://github.com/advisories/GHSA-p8p7-x288-28g6
No fix available
node_modules/request
  @kubernetes/client-node  *
  Depends on vulnerable versions of request
  node_modules/@kubernetes/client-node
@HedleyWard HedleyWard changed the title Security Vulnerability as client use depreciated Request library Moderate Security Vulnerability as client uses depreciated Request library Mar 23, 2023
@mstruebing
Copy link
Member

There is no specific timeline but it is worked on to replace refetch.
If you want to help there is a markdown file called fetch migration in the release-1.x branch with the current state.

@brendandburns
Copy link
Contributor

Closing as duplicate in favor of #414 and #754

We're (very) happy to take PRs to help complete this migration.

@brendandburns
Copy link
Contributor

Note also that I do not believe that this vulnerability affects this client because it is intended to talk exclusively to a Kubernetes cluster that you control, and if your cluster is owned enough that it is doing malicious things, you have worse problems than this library...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants