Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes event patching - unquote event count #1559

Merged

Conversation

yue9944882
Copy link
Member

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2021
@brendandburns
Copy link
Contributor

/lgtm
/approve

@yue9944882 is this worth cherry-picking?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 631bf1e into kubernetes-client:master Feb 25, 2021
@chris-chambers
Copy link

Does this really completely fix it? In my tests, Configuration.getDefaultApiClient().getJSON().serialize(now) did not produce a valid date string. It produced a JSON object representation that Kubernetes rejected. I had to switch to DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(now) to get a working event update. (There may be a more appropriate date formatting call, but that one worked for me.)

@yue9944882
Copy link
Member Author

@chris-chambers ah true, sry for being dump 🙁 really shouldn't have updated the timestamp serialization. i opened #1569 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventLogger produces unacceptable JSON Patches when updating events
4 participants