Ensure KubernetesInformerFactoryProcessor does not access any beans #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/L
asavov
reviewed
Feb 8, 2021
...java/io/kubernetes/client/spring/extended/controller/KubernetesInformerFactoryProcessor.java
Show resolved
Hide resolved
...java/io/kubernetes/client/spring/extended/controller/KubernetesInformerFactoryProcessor.java
Outdated
Show resolved
Hide resolved
...java/io/kubernetes/client/spring/extended/controller/KubernetesInformerFactoryProcessor.java
Outdated
Show resolved
Hide resolved
...java/io/kubernetes/client/spring/extended/controller/KubernetesInformerFactoryProcessor.java
Outdated
Show resolved
Hide resolved
...st/java/io/kubernetes/client/spring/extended/controller/KubernetesReconcilerCreatorTest.java
Show resolved
Hide resolved
...java/io/kubernetes/client/spring/extended/controller/KubernetesInformerFactoryProcessor.java
Outdated
Show resolved
Hide resolved
dsyer
force-pushed
the
informers
branch
2 times, most recently
from
b498e2b
to
e6b964e
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
A `BeanDefinitionRegistryPostProcessor` should not ideally refer to any bean instances, except lazily. This change makes the bean definitions that are installed by an `<at>KubernetesInformer` lazier by putting them behind a `Supplier` Signed-off-by: Dave Syer <dsyer@vmware.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsyer, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
BeanDefinitionRegistryPostProcessorshould not ideally refer to anybean instances, except lazily. This change makes the bean definitions
that are installed by a
@KubernetesInformerlazier by putting thembehind a
SupplierSee also #1516