Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateStatus() convenience methods to GenericKubernetesApi #1470

Merged
merged 1 commit into from Jan 4, 2021

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Jan 4, 2021

Fixes #1442, as a draft at least. We could refactor it to be more like the Golang API, e.g.

GenericKubernetesApi<T,L> api = ...;
api.status().update(...);

instead of

GenericKubernetesApi<T,L> api = ...;
api.updateStatus(...);

WDYT?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2021
Signed-off-by: Dave Syer <dsyer@vmware.com>
@brendandburns
Copy link
Contributor

/lgtm
/approve

I think that updateStatus is more congruent with the other Java APIs. I don't think that direct emulation of all of the client-go calls is necessarily the goal, I'd prefer to make this library as consistent with itself as possible.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dsyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 614f0de into kubernetes-client:master Jan 4, 2021
@karunasagark
Copy link

karunasagark commented Mar 3, 2021

@brendandburns @yue9944882, can we plan to include this in next release? maybe 11.1.0? I could send the cherry pick PR if you think thats a good idea.

@yue9944882
Copy link
Member

@karunasagark oops, we just had a new 11.0.x release a few hours ago, i suppose we will be getting a next release after getting a few more cherry-picks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement StatusWriter so you can patch just the status field in an API object
5 participants