Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the containerd version #2545

Open
xmudrii opened this issue Dec 19, 2022 · 3 comments
Open

Allow overriding the containerd version #2545

xmudrii opened this issue Dec 19, 2022 · 3 comments
Labels
Epic kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.

Comments

@xmudrii
Copy link
Member

xmudrii commented Dec 19, 2022

Description of the feature you would like to add / User story

As a cluster admin,
I would like to override the containerd version
in order to mitigate issues and regressions such as containerd/containerd#7828

Solution details

  • Extend the KubeOneCluster API to allow specifying the containerd version. For example:
    ...
    versions:
      kubernetes: 1.25.5
      containerd: '1.6.*'
    
  • Propagate the specified containerd version to machine-controller and operating-system-manager
    • Propagating the specified version to OSM might be a bit complicated due to the nature of OSPs. This is something that we still need to discuss.

Additional information

  • We should still enforce a compatibility matrix with this feature. Users shouldn't be allowed to override the containerd version to the next minor version (e.g. from 1.6 to 1.7) before we validate it.
@xmudrii xmudrii added kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. Epic labels Dec 19, 2022
@fbskp
Copy link

fbskp commented Dec 19, 2022

+1

Is it possible to upgrade to containerd 1.6.14 ASAP?
The aforementioned bug breaks a lot of deployments (basically all deployments which have memory resources set).

@xmudrii
Copy link
Member Author

xmudrii commented Dec 19, 2022

Is it possible to upgrade to containerd 1.6.14 ASAP?

KubeOne is using the latest available containerd version by default, in this case, 1.6.14. For control plane and static worker nodes, you can upgrade containerd by forcing upgrade, i.e. by running kubeone apply --force-upgrade. For worker nodes managed by machine-controller, you can rollout MachineDeployments as described in docs.

@fbskp
Copy link

fbskp commented Dec 20, 2022

@xmudrii Thanks - I already tried it yesterday (~ 4 hours after containerd 1.6.14 release) and it didn't pull the newest version. Today it worked just fine, maybe there is some cache in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Development

No branches or pull requests

2 participants