Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CI to check whether the corresponding translations has been generated #489

Open
Shelley-BaoYue opened this issue Dec 12, 2023 · 5 comments · May be fixed by #520
Open

Add a CI to check whether the corresponding translations has been generated #489

Shelley-BaoYue opened this issue Dec 12, 2023 · 5 comments · May be fixed by #520
Assignees
@YashPimple @shashank-iitbhu
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@Shelley-BaoYue
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When we do any changes in website pages, we need to use yarn write-translations --locale zh to generate the Chinese version. However, sometimes we may ignore this step or manually add it, which does not correspond to the English version.

Describe the solution you'd like

Add a CI to check whether the corresponding Chinese translation version is generated, mainly including the following files: https://github.com/kubeedge/website/blob/master/i18n/zh/code.json. https://github.com/kubeedge/website/blob/master/i18n/zh/docusaurus-theme-classic/navbar.json and etc.

We can run yarn write-translations --locale zh in CI and git status to check if any new changes occurs.
@Shelley-BaoYue Shelley-BaoYue mentioned this issue Dec 12, 2023
Merged
3 tasks
@Shelley-BaoYue
Copy link
Collaborator Author

/help wanted

@Shelley-BaoYue Shelley-BaoYue added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 12, 2023
@fisherxu fisherxu added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 13, 2023
@shashank-iitbhu
Copy link

/assign

@Shelley-BaoYue
Copy link
Collaborator Author

/assign

Welcome! Feel free to communicate here if you have any questions. 😄

@YashPimple
Copy link

Hi @shashank-iitbhu are you still on the ticket since i would like to give it a try

@YashPimple YashPimple linked a pull request Feb 9, 2024 that will close this issue
Open
@YashPimple
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YashPimple YashPimple

@shashank-iitbhu shashank-iitbhu

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add: ci/cd workflow to verify chinese translations YashPimple/kubeedge-website
4 participants
@fisherxu @Shelley-BaoYue @YashPimple @shashank-iitbhu