Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing Twitter with X #543

Merged
merged 1 commit into from
May 25, 2024
Merged

Replacing Twitter with X #543

merged 1 commit into from
May 25, 2024

Conversation

1Shubham7
Copy link
Contributor

@1Shubham7 1Shubham7 commented May 17, 2024 •
edited

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs update

  • What is the current behavior? (You can also link to an open issue here)
    We have a Twitter logo.

solves a part of #533

  • What is the new behavior (if this is a feature change)?
    I have replaced the twitter logo with X

Closes #444
Closes #390

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@1Shubham7
Replacing Twitter with X
a3a34e3 
Signed-off-by: GitHub <noreply@github.com>
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2024
@1Shubham7
Copy link
Contributor Author

@fisherxu @wbc6080, should we also replace Twitter as text with X in various parts of the docs? example

wbc6080
wbc6080 reviewed May 25, 2024
View reviewed changes
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2024
Shelley-BaoYue
Shelley-BaoYue reviewed May 25, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!
/lgtm

@Shelley-BaoYue
Copy link
Collaborator

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shelley-BaoYue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2024
@kubeedge-bot kubeedge-bot merged commit e7fb865 into kubeedge:master May 25, 2024
6 checks passed
@Shelley-BaoYue Shelley-BaoYue mentioned this pull request May 27, 2024
Closed
3 tasks
@1Shubham7 1Shubham7 mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbc6080 wbc6080 wbc6080 left review comments

@Shelley-BaoYue Shelley-BaoYue Shelley-BaoYue left review comments

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@wbc6080 wbc6080

@Shelley-BaoYue Shelley-BaoYue

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change twitter icon to X icon Changing the Twitter logo from bird to X
4 participants
@1Shubham7 @Shelley-BaoYue @kubeedge-bot @wbc6080