Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive PartialEq for DynamicObject #1048

Merged
merged 1 commit into from Oct 12, 2022

Conversation

pbzweihander
Copy link
Contributor

Motivation

  • Fields of DynamicObject all implement PartialEq
  • It would be convenient if DynamicObject implements PartialEq, too.

Solution

  • Add PartialEq derive to DynamicObject

Signed-off-by: pbzweihander <pbzweihander@gmail.com>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, cheap thing to have. Particularly since k8s-openapi also derive PartialEq for their types.

Thanks!

@clux clux added the changelog-add changelog added category for prs label Oct 12, 2022
@clux clux added this to the 0.76.0 milestone Oct 12, 2022
@clux clux merged commit b92dc5b into kube-rs:main Oct 12, 2022
@pbzweihander pbzweihander deleted the dynamic-object-partialeq branch October 13, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants