Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokio 1.0 #339

Closed
2 tasks done
clux opened this issue Nov 11, 2020 · 8 comments · Fixed by #363 or #374
Closed
2 tasks done

tokio 1.0 #339

clux opened this issue Nov 11, 2020 · 8 comments · Fixed by #363 or #374

Comments

@clux
Copy link
Member

clux commented Nov 11, 2020

Just a tracking issue for the tokio 0.3 upgrade.

A couple of things needed;

@jmjoy
Copy link

jmjoy commented Dec 2, 2020

Maybe wait tokio 1.0? Because:

The Tokio team plans to release Tokio 1.0 by the end of December 2020.

https://tokio.rs/blog/2020-10-tokio-0-3

@clux
Copy link
Member Author

clux commented Dec 2, 2020

Oh, if that's true, then might as well wait with releasing a new version that depends on a new tokio.

However; if the point of a beta is that the ecosystem has some time to test it out, then maybe that date will be delayed? Reqwest and others haven't caught up to the beta yet.

@nightkr nightkr changed the title tokio 0.3 tokio 1.0 Dec 23, 2020
@nightkr
Copy link
Member

nightkr commented Dec 23, 2020

Tokio 1.0 is out, so 0.3 seems a bit moot now.. :P

@nightkr
Copy link
Member

nightkr commented Dec 29, 2020

Progress tracker:

nightkr added a commit to nightkr/kube-rs that referenced this issue Jan 1, 2021
@nightkr nightkr mentioned this issue Jan 1, 2021
@clux clux closed this as completed in #363 Jan 4, 2021
@clux
Copy link
Member Author

clux commented Jan 4, 2021

i'll keep this open until we do a release with it in (blocked by reqwest making a release)

@clux clux reopened this Jan 4, 2021
@clux clux added the blocked awaiting upstream work label Jan 4, 2021
@jbg
Copy link
Contributor

jbg commented Jan 5, 2021

For anyone wanting to use a git dependency on kube to try this out, note that dependency patching only works in the root crate of a dependency tree, so you'll need to copy the patch from kube's Cargo.toml into yours:

[patch.crates-io]
# https://github.com/seanmonstar/reqwest/pull/1076 hasn't been released yet
reqwest = { git = "https://github.com/seanmonstar/reqwest.git", rev = "1f425a0244bcd7b4565dceb9076450d951f2ec03" }

@kazk
Copy link
Member

kazk commented Jan 5, 2021

reqwest v0.11.0 was released: seanmonstar/reqwest#1133

@clux clux closed this as completed in #374 Jan 5, 2021
@clux clux removed the blocked awaiting upstream work label Jan 6, 2021
@clux
Copy link
Member Author

clux commented Jan 6, 2021

published in kube* 0.47.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants