Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustls auth_provider oauth support #120

Closed
clux opened this issue Feb 1, 2020 · 7 comments
Closed

rustls auth_provider oauth support #120

clux opened this issue Feb 1, 2020 · 7 comments
Labels
config Kube config related help wanted Not immediately prioritised, please help!

Comments

@clux
Copy link
Member

clux commented Feb 1, 2020

You will notice that the initial rustls support from #66 and #114, the oauth2 module was basically commented out leaving gke a bit unusable (or so I think).

Any help porting src/oauth2/mod.rs to rustls would be appreciated. It was mostly ynqa's work from the original source tree, with some help from @davidB recently I think. But anyone feel free to jump on it. I have done the bare minimum to allow some clusters to at least work with rustls.

@clux clux added config Kube config related enhancement help wanted Not immediately prioritised, please help! labels Feb 1, 2020
@NAlexPear
Copy link
Contributor

leaving gke a bit unusable (or so I think)

Just confirmed that this ☝️ is the case while working on a GKE cluster using load_kube_config() and service account credentials. RUST_BACKTRACE shows an unwrap error on one of these lines in the into_token method.

The problem doesn't exist in version 0.6, so sticking with that version for now.

@clux
Copy link
Member Author

clux commented Feb 7, 2020

Wait, is this the case default features? It should only affect rustls-tls installations.

@davidB
Copy link
Contributor

davidB commented Feb 7, 2020

I don't have GKE cluster, next week-end I'll re-setup a GKE cluster to take a look at this issue, and see If I can help

@NAlexPear
Copy link
Contributor

I was running with the openapi feature only, but if this behavior is surprising, then I'll do my best to get you a more concrete repro later today.

@davidB
Copy link
Contributor

davidB commented Feb 8, 2020

@NAlexPear I was able to reproduce the issue with into_token, it was caused by a 400 response from gke during the refresh (I don't know why), the PR #123 includes display of the response from gke if response is not OK.

@clux
Copy link
Member Author

clux commented Feb 9, 2020

Have released this PR in 0.25.0 (first rustls support release)

@clux clux removed the enhancement label Feb 27, 2020
@clux
Copy link
Member Author

clux commented Feb 10, 2021

This issue should have been closed a while ago.
As it stands the rustls-tls switches everything at the moment, and oauth for gcp is done via tame_oauth now.

@clux clux closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Kube config related help wanted Not immediately prioritised, please help!
Projects
None yet
Development

No branches or pull requests

3 participants