Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create_subresource method to Api and create_token_request method to Api<ServiceAccount> #989

Merged
merged 6 commits into from Aug 19, 2022
Merged

Add create_subresource method to Api and create_token_request method to Api<ServiceAccount> #989

merged 6 commits into from Aug 19, 2022

Conversation

pbzweihander
Copy link
Contributor

Motivation

Solution

  • Add create_subresource method to Api to create arbitrary subresource.
  • Add create_token_request method to Api<ServiceAccount>

@pbzweihander
Add create_subresource method to Request
ccf8b2a 
Signed-off-by: pbzweihander <pbzweihander@gmail.com>
@pbzweihander
Add create_subresource method to Api
fb85de4 
Signed-off-by: pbzweihander <pbzweihander@gmail.com>
@pbzweihander
Add create_token_request method to Api<ServiceAccount>
080c923 
Signed-off-by: pbzweihander <pbzweihander@gmail.com>
@clux
Copy link
Member

clux commented Aug 18, 2022

Thanks a lot for doing this. I think the base of this PR is pretty much there. Some tests for it would be great, I'll add some minor comment suggestions for that.

@clux clux added the changelog-add changelog added category for prs label Aug 18, 2022
@clux clux added this to the 0.75.0 milestone Aug 18, 2022
@clux clux mentioned this pull request Aug 18, 2022
Open
11 tasks
@pbzweihander
Add test for Request::create_subresource
c369efd 
Signed-off-by: pbzweihander <pbzweihander@gmail.com>
@pbzweihander
Copy link
Contributor Author

I added tests!

@pbzweihander pbzweihander requested a review from clux August 19, 2022 02:17
@pbzweihander
Add intergration test for Api::<ServiceAccount>::create_token_request
8706b3a 
Signed-off-by: pbzweihander <pbzweihander@gmail.com>
@pbzweihander
Create and delete ServiceAccount for integration test
40ee0cf 
Signed-off-by: pbzweihander <pbzweihander@gmail.com>
@pbzweihander
Copy link
Contributor Author

And I made the tests actually pass

clux
clux approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much!

@clux clux merged commit 251728e into kube-rs:master Aug 19, 2022
@pbzweihander pbzweihander deleted the create-token-request branch August 20, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
changelog-add changelog added category for prs
Projects
None yet
Milestone
0.75.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pbzweihander @clux