Remove tracing::instrument
from apply_debug_overrides
#958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When logs are configured with span events, for example:
A warning is always logged in
Config::infer()
becauseapply_debug_overrides
is always called, and has#[tracing::instrument(level = "warn")]
.Solution
Remove
#[tracing::instrument(level = "warn")]
because I'm not sure how this span is useful.Alternate Solution
Only call
apply_debug_overrides
when overrides are defined.Or add
skip(self)
(#[tracing::instrument(level = "warn", skip(self))]
) to minimize output.